Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal functions could be set private #18

Open
code423n4 opened this issue Nov 4, 2021 · 0 comments
Open

internal functions could be set private #18

code423n4 opened this issue Nov 4, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

Since no contract inherent from SwapUtils all internal functions could be set private. For example getD could be set private to save gas.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 4, 2021
code423n4 added a commit that referenced this issue Nov 4, 2021
@code423n4
pants issue #18
008ef54
@chickenpie347 chickenpie347 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4