Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirdropDistribution's public functions can be made external #187

Closed
code423n4 opened this issue Nov 10, 2021 · 1 comment
Closed

AirdropDistribution's public functions can be made external #187

code423n4 opened this issue Nov 10, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

hyh

Vulnerability details

AirdropDistribution's functions: updateEmission, available_supply are public, but are not called within the contract (both have internal versions) and can be made external to reduce calling costs.

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/AirdropDistribution.sol#L595
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 10, 2021
code423n4 added a commit that referenced this issue Nov 10, 2021
@code423n4
hyh issue #187
bd61981
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #121

@chickenpie347 chickenpie347 marked this as a duplicate of #121 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4