Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safeTransferFrom instead of transferFrom can improve safety and consistency #245

Closed
code423n4 opened this issue Nov 10, 2021 · 1 comment
Closed

Use safeTransferFrom instead of transferFrom can improve safety and consistency #245

code423n4 opened this issue Nov 10, 2021 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-bootfinance/blob/f102ee73eb320532c5a7c1e833f225c479577e39/vesting/contracts/Vesting.sol#L95-L95

vestingToken.transferFrom(msg.sender, address(this), _amount);

Recommendation

Change to:

vestingToken.safeTransferFrom(msg.sender, address(this), _amount);
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 10, 2021
code423n4 added a commit that referenced this issue Nov 10, 2021
@code423n4
WatchPug issue #245
c4b5882
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 4, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #31

@chickenpie347 chickenpie347 marked this as a duplicate of #31 Jan 4, 2022
@0xean 0xean added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chickenpie347 @0xean @code423n4