Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GaugeController.apply_transfer_ownership() emits ApplyOwnership events when the admin hasn't changed #80

Open
code423n4 opened this issue Nov 6, 2021 · 0 comments
Open

GaugeController.apply_transfer_ownership() emits ApplyOwnership events when the admin hasn't changed #80

code423n4 opened this issue Nov 6, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

The function GaugeController.apply_transfer_ownership() emits ApplyOwnership events when the admin hasn't changed and left as it was before that transaction.

Impact

There is no reason to emit these ApplyOwnership events because nothing has changed in the system. Such events are only going to confuse users.

Tool Used

Manual code review.

Recommended Mitigation Steps

Emit these events only when the new admin is different than the old one.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 6, 2021
code423n4 added a commit that referenced this issue Nov 6, 2021
@code423n4
pants issue #80
e167af2
@chickenpie347 chickenpie347 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
@0xean 0xean added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chickenpie347 @0xean @code423n4