Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State Variables could be declared immutable #87

Closed
code423n4 opened this issue Nov 7, 2021 · 1 comment
Closed

State Variables could be declared immutable #87

code423n4 opened this issue Nov 7, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

PranavG

Vulnerability details

Impact

The immutable attributes can help reduce gas costs. The variables that do no change after deployment can be marked immutable.
Examples :
vestingToken in Vesting.sol(#24)
multiSig in Vesting.sol(#25)
deployer in PublicSale.sol(#67)
burnAddress in PublicSale.sol(#68)
tgeContract in PublicSaleBatchWithdraw.sol(#22)

Recommended Mitigation Steps

Add the immutable attributes to state variables that never change after deployment.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 7, 2021
code423n4 added a commit that referenced this issue Nov 7, 2021
@code423n4
PranavG issue #87
b398147
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #1 , #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4