Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused Imports Increase the size of Deployment and Waste Gas #111

Closed
code423n4 opened this issue Nov 29, 2021 · 1 comment
Closed

Unused Imports Increase the size of Deployment and Waste Gas #111

code423n4 opened this issue Nov 29, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

Meta0xNull

Vulnerability details

Impact

There is no arithmetic calculation in Permissions.sol. Import SafeMath is just waste of Gas.

Proof of Concept

https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/Permissions.sol#L4
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/Permissions.sol#L13

Tools Used

Manual Review

Recommended Mitigation Steps

Remove Import SafeMath
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 29, 2021
code423n4 added a commit that referenced this issue Nov 29, 2021
@code423n4
Meta0xNull issue #111
3e0ee98
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 9, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 9, 2021

#157

@0xScotch 0xScotch closed this as completed Dec 9, 2021
@GalloDaSballo GalloDaSballo added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed G (Gas Optimization) labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4