Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code in unbond and unbondAndBreak functions #178

Open
code423n4 opened this issue Nov 30, 2021 · 1 comment
Open

Duplicated code in unbond and unbondAndBreak functions #178

code423n4 opened this issue Nov 30, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

nathaniel

Vulnerability details

Impact

A large portion of the unbond and unbondAndBreak code of Bonding.sol is the same, to reduce code bloat and gas when calling the contract

Proof of Concept

https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/Bonding.sol#L97-L109

Tools Used

Manual

Recommended Mitigation Steps

I would suggest wrapping the duplicated code into an internal function called by unbond and unbondAndBreak.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
@code423n4
nathaniel issue #178
7676e47
@0xScotch 0xScotch added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 9, 2021
@GalloDaSballo
Copy link
Collaborator

There's definitely duplication, because of how the code is written refactoring may not be trivial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4