Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decimals return of costBasis is not used. #205

Open
code423n4 opened this issue Nov 30, 2021 · 2 comments
Open

decimals return of costBasis is not used. #205

code423n4 opened this issue Nov 30, 2021 · 2 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

costBasis() function in SwingTrader.sol returns cost and decimals,
But decimals variable is not used in anywhere inside contract.

Tools Used

Manual

Recommended Mitigation Steps

Re-check if decimals is required, and remove if it’s not required.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
@code423n4
xYrYuYx issue #205
25867ea
@0xScotch 0xScotch added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 7, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 7, 2021

May not be used right now but could be useful to have in the future.

@GalloDaSballo
Copy link
Collaborator

Finding is valid, if the sponsor has a plan for using it, then a no-fix is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4