Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MovingAverage:getValueWithLookback move sampleDiff to save gas #212

Open
code423n4 opened this issue Nov 30, 2021 · 1 comment
Open

MovingAverage:getValueWithLookback move sampleDiff to save gas #212

code423n4 opened this issue Nov 30, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GiveMeTestEther

Vulnerability details

Impact

Move the initialization of sampleDiff below the if block to save gas in the case of return of the if block.

Proof of Concept

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/MovingAverage.sol#L128

Tools Used
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
@code423n4
GiveMeTestEther issue #212
7b7ff77
@0xScotch 0xScotch added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 10, 2021
@GalloDaSballo
Copy link
Collaborator

Agree, an early return will save gas

@GalloDaSballo GalloDaSballo mentioned this issue Jan 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4