Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splitReinvest does not provide liquidity at optimal ratio #253

Open
code423n4 opened this issue Dec 1, 2021 · 2 comments
Open

splitReinvest does not provide liquidity at optimal ratio #253

code423n4 opened this issue Dec 1, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The RewardReinvestor.splitReinvest splits the reward token in half and trades half of it to malt, then provides liquidity in the same pool.

This is not optimal as the trade comes with fees and slippage and the reserve ratios don't exactly equal the reward / malt ratio used to provide LP.

For more info, see here.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 1, 2021
code423n4 added a commit that referenced this issue Dec 1, 2021
@code423n4
cmichel issue #253
31d1b3b
@0xScotch 0xScotch added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 4, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 4, 2021

This should be improved but will likely come in a future update unless we have the time before launch to implement this correctly. Not highest priority

@GalloDaSballo
Copy link
Collaborator

Finding is valid and surprisingly deep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4