Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas: unnecessary safe math in addLiquidity 2 #261

Closed
code423n4 opened this issue Dec 1, 2021 · 1 comment
Closed

Gas: unnecessary safe math in addLiquidity 2 #261

code423n4 opened this issue Dec 1, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The UniswapHandler.addLiquidity function performs a safe math computation as rewardBalance.sub(rewardUsed) but the if condition already verified that rewardUsed < rewardBalance and therefore an unsafe subtraction can be used.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 1, 2021
code423n4 added a commit that referenced this issue Dec 1, 2021
@code423n4
cmichel issue #261
3a8bebf
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 8, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 8, 2021

#307

@0xScotch 0xScotch closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xScotch @code423n4