Better packing of struct AuctionData to save gas

[code423n4]

Handle

tabish

Vulnerability details

Impact

Detailed description of the impact of this finding.

Struct AuctionData https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Auction.sol#L26 currently uses 16 slots + mapping size . It is pack it more efficiently to save gas.

Recommended Mitigation Steps

Change Struct AuctionData to:

struct AuctionData {
  // The full amount of commitments required to return to peg
  uint256 fullRequirement;
  // total maximum desired commitments to this auction
  uint256 maxCommitments;
  // Quantity of sale currency committed to this auction
  uint256 commitments;
  // Malt purchased and burned using current commitments
  uint256 maltPurchased;
  // Desired starting price for the auction
  uint256 startingPrice;
  // Desired lowest price for the arbitrage token
  uint256 endingPrice;
  // Price of arbitrage tokens at conclusion of auction. This is either
  // when the duration elapses or the maxCommitments is reached
  uint256 finalPrice;
  // The peg price for the liquidity pool
  uint256 pegPrice;
  // Time when auction started
  uint256 startingTime;
  uint256 endingTime;
  // The reserve ratio at the start of the auction
  uint256 preAuctionReserveRatio;
  // The amount of arb tokens that have been executed and are now claimable
  uint256 claimableTokens;
  // The finally calculated realBurnBudget
  uint256 finalBurnBudget;
  // The amount of Malt purchased with realBurnBudget
  uint256 finalPurchased;
  // Has this auction been finalized? Meaning any additional stabilizing
  // has been done
  bool finalized;
  // Is the auction currently accepting commitments?
  bool active;
  // A map of all commitments to this auction by specific accounts
  mapping(address => AccountCommitment) accountCommitments;
}

[0xScotch]

#38

[GalloDaSballo]

Duplicate of #38