UniswapHandler - Unneccessary safe math usage

[code423n4]

Handle

ScopeLift

Vulnerability details

Impact

Gas can be saved inside the addLiquidity function by avoiding the usage of safe math where the overflow condition has already been checked via conditional.

Proof of Concept

N/A

Tools Used

N/A

Recommended Mitigation Steps

Update amounts used in transfer calls to use unchecked subtraction:

    if (maltUsed < maltBalance) {
      malt.safeTransfer(msg.sender, maltBalance - maltUsed);
    }

    if (rewardUsed < rewardBalance) {
      rewardToken.safeTransfer(msg.sender, rewardBalance - rewardUsed);
    }

[0xScotch]

#307

[GalloDaSballo]

Duplicate of #307