Unbounded loops

[code423n4]

Handle

pauliax

Vulnerability details

Impact

There are several loops in the contract which can eventually grow so large as to make future operations of the contract cost too much gas to fit in a block, e.g.:

  for (uint256 i = replenishingIndex; i < auctionIds.length; i = i + 1) // function outstandingArbTokens()
  while (true) // function allocateArbRewards

Recommended Mitigation Steps

Consider introducing a reasonable upper limit based on block gas limits. Also, you can consider using EnumerableSet (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/structs/EnumerableSet.sol) where possible, e.g. 'buyers' or 'verifierList'.

[GalloDaSballo]

Agree with the finding, would have preferred a list of occurencies though as this message doesn't help the sponsor mitigate