Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auction.userClaimableArbTokens nonzero auction.finalPrice check is redundant #49

Open
code423n4 opened this issue Nov 27, 2021 · 1 comment
Open

Auction.userClaimableArbTokens nonzero auction.finalPrice check is redundant #49

code423n4 opened this issue Nov 27, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

hyh

Vulnerability details

Proof of Concept

As there is a check in the beginning of the function that includes the auction.finalPrice == 0 condition:
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/Auction.sol#L285

Recommended Mitigation Steps

The same condition down the line is never true and its check is redundant:
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/Auction.sol#L298
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 27, 2021
code423n4 added a commit that referenced this issue Nov 27, 2021
@code423n4
hyh issue #49
11c63c0
@0xScotch 0xScotch added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 8, 2021
This was referenced Dec 8, 2021
Closed
Closed
@GalloDaSballo
Copy link
Collaborator

Agree with finding, the second if can't happen as the function will return 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4