Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Import #62

Closed
code423n4 opened this issue Nov 27, 2021 · 2 comments
Closed

Redundant Import #62

code423n4 opened this issue Nov 27, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

defsec

Vulnerability details

Impact

Hardhat console is an unnecessary import in all contracts since it is used solely for development. It can therefore be removed.

Proof of Concept

  1. Navigate to the following contracts.

"https://github.com/code-423n4/2021-11-malt/blob/d3f6a57ba6694b47389b16d9d0a36a956c5e6a94/src/contracts/RewardSystem/RewardThrottle.sol#L14"

"https://github.com/code-423n4/2021-11-malt/blob/d3f6a57ba6694b47389b16d9d0a36a956c5e6a94/src/contracts/RewardSystem/RewardDistributor.sol#L12"

Tools Used

None

Recommended Mitigation Steps

Consider to delete 'import "hardhat/console.sol"' for the gas optimization.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 27, 2021
code423n4 added a commit that referenced this issue Nov 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 9, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 9, 2021

#157

@0xScotch 0xScotch closed this as completed Dec 9, 2021
@GalloDaSballo
Copy link
Collaborator

Duplicate of #157

@GalloDaSballo GalloDaSballo marked this as a duplicate of #157 Jan 1, 2022
@CloudEllie CloudEllie added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed G (Gas Optimization) labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants