functions visibility on contract Timelock.sol

[code423n4]

Handle

BouSalman

Vulnerability details

Vulnerability description

On contract Timelock there is multiple functions labeled as Public, However these functions are not used within the contract of Malt protocol.

Impact

Improve coding style quality for developers and audit.

Proof of Concept

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L66
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L82
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L98
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L107
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L132
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Timelock.sol#L150

Tools Used

manual code review.

Recommended Mitigation Steps

Evaluate functions labeled as public and set to external if needed.

[GalloDaSballo]

Not sure why the sponsor disputed

Through a quick search in the source code I can tell the functions are not called within the contract nor it's children (no contract inherits from Timelock)
As such I agree with the warden in that external seems to be a more appropriate visibility