Unable to remove operator at index 0

[code423n4]

Handle

gzeon

Vulnerability details

Impact

Unable to remove operator at index 0

Proof of Concept

https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L84
revert when i == 0

Recommended Mitigation Steps

Remove the require statement as if not found it would revert due to OOB in L81;
or rewrite as follow to yield proper revert

    function removeOperator(bytes32 operator) external override onlyOwner {
        uint256 i = 0;
        uint256 len = operators.length; // Gas optimization
        while (operators[i] != operator && i < len) {
            i++;
        }
        require(i < len, "NestedFactory::removeOperator: Cant remove non-existent operator");
        delete operators[i];
    }

[maximebrugel]

Duplicated : #58

[alcueca]

Using #220 instead