Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function NestedFactory::removeOperator forbids removing first operator #69

Closed
code423n4 opened this issue Nov 15, 2021 · 2 comments
Closed

Function NestedFactory::removeOperator forbids removing first operator #69

code423n4 opened this issue Nov 15, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Impact

The function removeOperator in NestedFacotry.sol requires that the operator
to remove has an index greater than 0, see line 84.

This disabled the functionality of removing the operator at index 0, i.e. the
first added operator.

Recommended Mitigation Steps

Remove the require statement.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
pmerkleplant issue #69
64190fe
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 16, 2021
@maximebrugel
Copy link
Collaborator

Duplicated : #58

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Using #220 instead

@alcueca alcueca added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4