The require condition is not correct in function removeOperator in NestedFactory.sol

[code423n4]

Handle

fatima_naz

Vulnerability details

Impact

in function removeOperator in NestedFactory.sol
function removeOperator(bytes32 operator) external override onlyOwner {
uint256 i = 0;
while (operators[i] != operator) {
i++;
}
require(i > 0, "NestedFactory::removeOperator: Cant remove non-existent operator");
delete operators[i];
}

In the require condition i>0 but if the first element of operators i.e. operators[0] is equal to the operator the while loop will break just then. so i is 0 but require condition checks for i>0 so it will show that "NestedFactory::removeOperator: Cant remove non-existent operator" but actually the operator exist and it needs to be removed.

Proof of Concept

Tools Used

Recommended Mitigation Steps

change the condition in require as i>=0

[maximebrugel]

Duplicated : #58

[alcueca]

Using #220