Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unchecked to save gas #94

Closed
code423n4 opened this issue Nov 16, 2021 · 1 comment
Closed

use unchecked to save gas #94

code423n4 opened this issue Nov 16, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

NestedFactory.sol line 82 use unchecked to save gas since no need to do safe math there. (No overflow/underflow possibility).
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 16, 2021
code423n4 added a commit that referenced this issue Nov 16, 2021
@code423n4
pants issue #94
fe6d624
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 19, 2021
@maximebrugel
Copy link
Collaborator

The code will change with the #58 resolution. However, we will not use unchecked { ++i }, it's a duplicate of #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximebrugel @code423n4