Use a constant instead of block.timestamp for the deadline

[code423n4]

Handle

defsec

Vulnerability details

Impact

When doing swaps with a Uniswap router from within a contract, there's no need to compute any offset from the current block for the deadline parameter.
The router just checks if deadline >= block.timestamp.

Proof of Concept

1. Navigate to the following contract.

https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/singleJoinExit/SingleTokenJoinV2.sol#L109

Tools Used

None

Recommended Mitigation Steps

The most efficient way to provide deadlines for a router swap is to use a hardcoded value that is far in the future, for example, 1e10.