Use of unsafe transfer()

[code423n4]

Handle

p4st13r4

Vulnerability details

Impact

Contracts in the folder basket/contracts/singleJoinExit makes use of unsafe address.transfer() method.

The use of such function could have unintended outcomes on the eth being sent to the receiver. Funds can potentially be lost if:

1. The smart contract fails to implement the payable fallback function
2. The fallback function uses more than 2300 gas units

The latter situation may occur in the instance of gas cost changes. The impact would mean that any contracts receiving funds would potentially be unable to retrieve funds

Proof of Concept

Affected lines are here:

• contracts/basket/contracts/singleJoinExit/EthSingleTokenJoin.sol:37
• contracts/basket/contracts/singleJoinExit/EthSingleTokenJoinV2.sol:37
• contracts/basket/contracts/singleJoinExit/SingleNativeTokenExit.sol:93
• contracts/basket/contracts/singleJoinExit/SingleNativeTokenExitV2.sol:121

Tools Used

Editor

Recommended Mitigation Steps

Consider using address.call{value: v}("") and checking the return value or Openzeppelin Address library instead

[loki-sama]

Duplicate #231

[0xleastwood]

Duplicate of #175