Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public functions to external #17

Closed
code423n4 opened this issue Dec 14, 2021 · 1 comment
Closed

Public functions to external #17

code423n4 opened this issue Dec 14, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following functions could be set external to save gas and improve code quality.
External call cost is less expensive than of public functions.

    The function chargeOutstandingAnnualizedFee in BasketFacet.sol could be set external
    The function calcOutStandingAnnualizedFee in BasketFacet.sol could be set external
    The function balance in BasketFacet.sol could be set external
    The function callNoValue in CallFacet.sol could be set external
    The function call in CallFacet.sol could be set external
    The function initialize in MintableERC20.sol could be set external
    The function initialize in PolygonERC20Wrapper.sol could be set external
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 14, 2021
code423n4 added a commit that referenced this issue Dec 14, 2021
@ghost ghost added sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons and removed sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue labels Dec 30, 2021
@0xleastwood
Copy link
Collaborator

Duplicate of #174

@0xleastwood 0xleastwood marked this as a duplicate of #174 Jan 24, 2022
@0xleastwood 0xleastwood added the duplicate This issue or pull request already exists label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants