Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary struct in SingleNativeTokenExitV2 #177

Open
code423n4 opened this issue Dec 19, 2021 · 0 comments
Open

Unnecessary struct in SingleNativeTokenExitV2 #177

code423n4 opened this issue Dec 19, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

kenzo

Vulnerability details

These are the structs in SingleNativeTokenExitV2: (Code ref)

struct ExitUnderlyingTrade {
        ExitUniswapV2SwapStruct[] swaps;
    }

    struct ExitUniswapV2SwapStruct {
        address exchange;
        address[] path;
    }
    struct ExitTokenStructV2 {
        address inputBasket;
        uint256 inputAmount;
        uint256 minAmount;
        uint256 deadline;
        uint16 referral;
        ExitUnderlyingTrade[] trades;
    }

ExitTokenStructV2 contains an array of ExitUnderlyingTrade , and ExitUnderlyingTrade is just an array of ExitUniswapV2SwapStruct. So ExitUnderlyingTrade is unnecessary.
For clarity, I suggest removing ExitUnderlyingTrade and just having an array of ExitUniswapV2SwapStruct in ExitTokenStructV2 .

@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant