We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IWrappedNativeToken.deposit()
WatchPug
To wrap native token, using IWrappedNativeToken.deposit() is more gas efficient than .call{value: msg.value}().
.call{value: msg.value}()
https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/singleJoinExit/EthSingleTokenJoin.sol#L26-L26
address(INTERMEDIATE_TOKEN).call{value: msg.value}("");
https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/singleJoinExit/EthSingleTokenJoinV2.sol#L26-L26
Change to:
IWrappedNativeToken(address(INTERMEDIATE_TOKEN)).deposit{ value: msg.value }();
The text was updated successfully, but these errors were encountered:
WatchPug issue #184
0927e5a
No branches or pull requests
Handle
WatchPug
Vulnerability details
To wrap native token, using
IWrappedNativeToken.deposit()
is more gas efficient than.call{value: msg.value}()
.https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/singleJoinExit/EthSingleTokenJoin.sol#L26-L26
https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/singleJoinExit/EthSingleTokenJoinV2.sol#L26-L26
Recommendation
Change to:
The text was updated successfully, but these errors were encountered: