Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loss of precision when calculating the annualized fee #187

Closed
code423n4 opened this issue Dec 19, 2021 · 1 comment
Closed

Loss of precision when calculating the annualized fee #187

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The BasketFacet.calcOutStandingAnnualizedFee function calculates the pending fee as:

// @audit reorder div to end to not lose precision?
totalSupply.mul(annualizedFee).div(10**18).mul(timePassed).div(
    365 days
);

The early division by 1e18 will lead to a loss of precision. Slightly fewer fees will be collected.

Recommended Mitigation Steps

Generally, it's recommended to first do all multiplications before doing the divisions to not lose precision due to integer divisions.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
cmichel issue #187
bfcabcd
@0xleastwood
Copy link
Collaborator

Duplicate of #155

@0xleastwood 0xleastwood marked this as a duplicate of #155 Jan 23, 2022
@0xleastwood 0xleastwood added the duplicate This issue or pull request already exists label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4