New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`10 ** 18` can be changed to `1e18` and save some gas #203

Open

code423n4 opened this issue Dec 19, 2021 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Dec 19, 2021

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/BasketFacet.sol#L158

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/BasketFacet.sol#L177

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/BasketFacet.sol#L354

10 ** 18 can be changed to 1e18 to avoid unnecessary arithmetic operation and save gas.

The text was updated successfully, but these errors were encountered:

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          WatchPug issue #203

6037aa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment