We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WatchPug
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/shared/Access/CallProtection.sol#L8-L12
require( msg.sender == LibDiamond.diamondStorage().contractOwner || msg.sender == address(this), "NOT_ALLOWED" );
Can be changed to:
require( msg.sender == address(this) || msg.sender == LibDiamond.diamondStorage().contractOwner, "NOT_ALLOWED" );
When msg.sender != address(this), can exit earlier and avoiding more expensive check of msg.sender == LibDiamond.diamondStorage().contractOwner.
msg.sender != address(this)
msg.sender == LibDiamond.diamondStorage().contractOwner
The text was updated successfully, but these errors were encountered:
WatchPug issue #209
f977ede
No branches or pull requests
Handle
WatchPug
Vulnerability details
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/shared/Access/CallProtection.sol#L8-L12
Can be changed to:
When
msg.sender != address(this)
, can exit earlier and avoiding more expensive check ofmsg.sender == LibDiamond.diamondStorage().contractOwner
.The text was updated successfully, but these errors were encountered: