Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short circuiting can save gas #209

Open
code423n4 opened this issue Dec 19, 2021 · 0 comments
Open

Use short circuiting can save gas #209

code423n4 opened this issue Dec 19, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/shared/Access/CallProtection.sol#L8-L12

require(
    msg.sender == LibDiamond.diamondStorage().contractOwner ||
        msg.sender == address(this),
    "NOT_ALLOWED"
);

Can be changed to:

require(
    msg.sender == address(this) ||
        msg.sender == LibDiamond.diamondStorage().contractOwner,
    "NOT_ALLOWED"
);

When msg.sender != address(this), can exit earlier and avoiding more expensive check of msg.sender == LibDiamond.diamondStorage().contractOwner.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant