Caching array length can save gas

[code423n4]

Handle

robee

Vulnerability details

Caching the array length is more gas efficient.
This is because access to a local variable in solidity is more efficient than query storage / calldata / memory
We recommend to change from:
for (uint256 i=0; i<array.length; i++) { ... }
to:
uint len = array.length
for (uint256 i=0; i<len; i++) { ... }
These functions use not using prefix increments (++x) or not using the unchecked keyword:

    RebalanceManager.sol, _swapsV2, 218
    RebalanceManager.sol, _swapsV3, 234
    RebalanceManagerV2.sol, _swapsV2, 155
    RebalanceManagerV3.sol, _swapsV2, 166
    BasketFacet.sol, tokens.bs, 50
    BasketFacet.sol, tokens.bs, 160
    BasketFacet.sol, tokens.bs, 202
    BasketFacet.sol, tokens, 321
    BasketFacet.sol, tokens.bs, 348
    BasketFacet.sol, tokens.bs, 381
    CallFacet.sol, callers.callStorage, 55
    CallFacet.sol, _targets, 82
    CallFacet.sol, _targets, 95
    PieFactoryContract.sol, _tokens, 88
    SingleNativeTokenExit.sol, tokens, 69
    SingleNativeTokenExitV2.sol, trades._exitTokenStruct, 74
    SingleTokenJoin.sol, tokens, 108
    SingleTokenJoinV2.sol, trades._joinTokenStruct, 86
    SingleTokenJoinV2.sol, tokens, 117

[loki-sama]

duplicate #288

[0xleastwood]

Duplicate of #249