Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimization: Cache length for iterations #234

Closed
code423n4 opened this issue Dec 19, 2021 · 1 comment
Closed

Gas Optimization: Cache length for iterations #234

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

gzeon

Vulnerability details

e.g.
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/BasketFacet.sol#L49

        uint256 length = bs.tokens.length;
        // remove token from array
        for (uint256 i; i < length; i++) {
            if (address(bs.tokens[i]) == _token) {
                bs.tokens[i] = bs.tokens[length - 1];
                bs.tokens.pop();
                emit TokenRemoved(_token);
                break;
            }
        }
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@ghost ghost added the duplicate This issue or pull request already exists label Dec 30, 2021
@ghost ghost closed this as completed Jan 10, 2022
@0xleastwood
Copy link
Collaborator

Duplicate of #249

@0xleastwood 0xleastwood marked this as a duplicate of #249 Jan 24, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

2 participants