Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache bs.token.length in BacketFacet.sol #246

Closed
code423n4 opened this issue Dec 19, 2021 · 1 comment
Closed

Cache bs.token.length in BacketFacet.sol #246

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

In calcTokensForAmountExit and calcTokensForAmount, bs.token.length is used thrice. It would be more gas efficient to simply cache it.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
0x0x0x issue #246
98b894e
@0xleastwood
Copy link
Collaborator

Duplicate of #249 from same warden.

@0xleastwood 0xleastwood added the invalid This doesn't seem right label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4