Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing zero address check in setRebalanceManager #255

Open
code423n4 opened this issue Dec 19, 2021 · 1 comment
Open

Missing zero address check in setRebalanceManager #255

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

hubble

Vulnerability details

Impact

Missing zero address check in setRebalanceManager function of RebalanceManager.sol, RebalanceManagerV2.sol and RebalanceManagerV3.sol

Proof of Concept

Files : RebalanceManager.sol, RebalanceManagerV2.sol and RebalanceManagerV3.sol
Function : setRebalanceManager

function setRebalanceManager(address _rebalanceManager)
    external
    onlyRebalanceManager
{
    rebalanceManager = _rebalanceManager;
    emit RebalanceManagerSet(_rebalanceManager);
}

Tools Used

Manual Review

Recommended Mitigation Steps

Add check for zero address in the function setRebalanceManager on all the three RebalanceManager files.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
hubble issue #255
f694996
@0xleastwood
Copy link
Collaborator

No direct security risk, marking as non-critical

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4