Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It might not be possible to withdraw tokens from the basket #287

Open
code423n4 opened this issue Dec 19, 2021 · 1 comment
Open

It might not be possible to withdraw tokens from the basket #287

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

Czar102

Vulnerability details

Impact

When enough basket token owners exit, it will be impossible to exit pool with the last MIN_AMOUNT tokens because of this check. This will result in locking some tokens forever.

Recommended Mitigation Steps

Consider resigning from this check or performing it only for the owner balance, who would need to have at least MIN_AMOUNT tokens.
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
Czar102 issue #287
c143279
@loki-sama loki-sama added help wanted Extra attention is needed duplicate This issue or pull request already exists and removed help wanted Extra attention is needed labels Dec 21, 2021
@loki-sama loki-sama added disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) labels Jan 4, 2022
@ghost ghost closed this as completed Jan 10, 2022
@0xleastwood
Copy link
Collaborator

Nice find! I think this is valid:)

@0xleastwood 0xleastwood reopened this Jan 22, 2022
@0xleastwood 0xleastwood removed the duplicate This issue or pull request already exists label Jan 22, 2022
@0xleastwood 0xleastwood mentioned this issue Jan 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@loki-sama @0xleastwood @code423n4