_maxApprove user input #289
Labels
0 (Non-critical)
Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation
bug
Something isn't working
sponsor disputed
Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Handle
pauliax
Vulnerability details
Impact
_maxApprove is called with spender address that comes from user input. While these contracts do not expect to hold any funds, an approved actor could later use the approval to rescue accidentally sent tokens or airdrops.
Recommended Mitigation Steps
Consider approving only the necessary amount or resetting the approval afterward, or even introducing a whitelist of trusted addresses.
The text was updated successfully, but these errors were encountered: