Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_swapsV3 after the _swapsV2 #291

Open
code423n4 opened this issue Dec 19, 2021 · 0 comments
Open

_swapsV3 after the _swapsV2 #291

code423n4 opened this issue Dec 19, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

contract RebalanceManager function rebalance first performs all the _swapsV2 and then all the _swapsV3. However, I imagine the could be a situation when the manager wants to mix these swaps, some v2, some v3 in between.

Recommended Mitigation Steps

Consider introducing a unified structure for v2 and v3 swaps so these can be mixed together in any order.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
pauliax issue #291
5edb51c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4