Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comment in LibBasketStorage.sol #79

Open
code423n4 opened this issue Dec 16, 2021 · 0 comments
Open

Incorrect comment in LibBasketStorage.sol #79

code423n4 opened this issue Dec 16, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Impact

The comment for the variable BasketStorage.exitFeeBeneficiaryShare states that
the fee goes to the pool (see line 18 in LibBasketStorage.sol).

However, the fee is not send to the pool itself, but rather to the BasketStorage.feeBeneficiary (see line 179 in BasketFacet.sol) which can be set to an arbitrary address.

Recommended Mitigation Steps

Change the comment to reflect that the fee goes to the feeBeneficiary, not the pool.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 16, 2021
code423n4 added a commit that referenced this issue Dec 16, 2021
@code423n4
pmerkleplant issue #79
458e9c7
@0xleastwood 0xleastwood mentioned this issue Jan 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4