Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtraction in ERC20Facet::decreaseApproval could be "unchecked" #80

Open
code423n4 opened this issue Dec 16, 2021 · 0 comments
Open

Subtraction in ERC20Facet::decreaseApproval could be "unchecked" #80

code423n4 opened this issue Dec 16, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Impact

The subtraction in ERC20Facet::decreaseApproval in line 128 could be unchecked, i.e. it's not necessary to use OZ's SafeMath::sub function here.

An underflow is not possible, as the expression is only called if oldValue >= _amount.

Recommended Mitigation Steps

Use solidity's builtin subtraction instead of OZ's SafeMath::sub to save gas
on unnecessary checks.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 16, 2021
code423n4 added a commit that referenced this issue Dec 16, 2021
@code423n4
pmerkleplant issue #80
fe3dd29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4