Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize variables with default value #85

Open
code423n4 opened this issue Dec 16, 2021 · 0 comments
Open

Don't initialize variables with default value #85

code423n4 opened this issue Dec 16, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

If a variable is not initialized, it is assumed to have the default value.
Explicitly initializing a variable with its default value costs unnecessary gas.

For more info, see Mudit Gupta's Blog at point "No need to initialize variables with default values".

Therefore, following variable declarations could be refactored:

./factories/PieFactoryContract.sol:88: for (uint256 i = 0; i < _tokens.length; i++)
./facets/Call/CallFacet.sol:55: for (uint256 i = 0; i < callStorage.callers.length; i++)
./facets/Call/CallFacet.sol:82: for (uint256 i = 0; i < _targets.length; i++)
./facets/Call/CallFacet.sol:95: for (uint256 i = 0; i < _targets.length; i++)
./facets/Basket/BasketFacet.sol:321: for (uint256 i = 0; i < tokens.length; i++)

Tools used

grep

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 16, 2021
code423n4 added a commit that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant