Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing check in constructor #10

Open
code423n4 opened this issue Jan 4, 2022 · 2 comments
Open

missing check in constructor #10

code423n4 opened this issue Jan 4, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

jah

Vulnerability details

Impact

Variable fee and feeto are only set in the constructor so they can only set once and there is no zero check which means if we accidentally set them to zero we can't change it

Proof of Concept

Phttps://github.com/code-423n4/2022-01-timeswap/blob/bf50d2a8bb93a5571f35f96bd74af54d9c92a210/Timeswap/Timeswap-V1-Core/contracts/TimeswapFactory.sol#L39

Tools Used

Manual analysis

Recommended Mitigation Steps

require( fee != 0 && feeto != address(0));
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 4, 2022
code423n4 added a commit that referenced this issue Jan 4, 2022
@code423n4
jah issue #10
e893ee4
@Mathepreneur Mathepreneur added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jan 18, 2022
@Mathepreneur
Copy link
Collaborator

We don't want it to change.

@0xean
Copy link
Collaborator

0xean commented Jan 25, 2022

working as designed, marking down to non critical.

@0xean 0xean added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @Mathepreneur @code423n4