Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtract values in the if statement to avoid a useless operation #124

Open
code423n4 opened this issue Jan 9, 2022 · 1 comment
Open

subtract values in the if statement to avoid a useless operation #124

code423n4 opened this issue Jan 9, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

OriDabush

Vulnerability details

TimeswapPair.sol - Gas Optimization

Lines 289-290 can be transferred into the if statements to avoid subtract 0 from the variables.

code before:

pool.state.reserves.asset -= tokensOut.asset;

pool.state.reserves.collateral -= tokensOut.collateral;

if (tokensOut.asset > 0) asset.safeTransfer(assetTo, tokensOut.asset);

if (tokensOut.collateral > 0) collateral.safeTransfer(collateralTo, tokensOut.collateral);

code after:

if (tokensOut.asset > 0) {
asset.safeTransfer(assetTo, tokensOut.asset);
pool.state.reserves.asset -= tokensOut.asset;
}

if (tokensOut.collateral > 0) {
collateral.safeTransfer(collateralTo, tokensOut.collateral);
pool.state.reserves.collateral -= tokensOut.collateral;
}
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 9, 2022
code423n4 added a commit that referenced this issue Jan 9, 2022
@code423n4
OriDabush issue #124
5c27ffa
@amateur-dev amateur-dev mentioned this issue Jan 15, 2022
Closed
@Mathepreneur Mathepreneur added sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) labels Jan 24, 2022
@Mathepreneur
Copy link
Collaborator

https://github.com/Timeswap-Labs/Timeswap-V1-Core/pull/90/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mathepreneur @code423n4