Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immutable variables fee and protocolFee are unbounded #128

Closed
code423n4 opened this issue Jan 9, 2022 · 1 comment
Closed

immutable variables fee and protocolFee are unbounded #128

code423n4 opened this issue Jan 9, 2022 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

In TimeswapFactory and TimeswapPair: immutable variables fee and protocolFee aren't bounded. It could get troublesome for users in the case of malicious/faulty governor contract.

Recommended Mitigation Steps

Set a max fee and a max protocolFee
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 9, 2022
code423n4 added a commit that referenced this issue Jan 9, 2022
@code423n4
Dravee issue #128
6bdc22d
@amateur-dev
Copy link
Collaborator

Similar issue reported over here #33; hence closing this issue

@amateur-dev amateur-dev added the duplicate This issue or pull request already exists label Jan 15, 2022
@0xean 0xean added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @amateur-dev @code423n4