Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated OpenZeppelin dependency #132

Open
code423n4 opened this issue Jan 10, 2022 · 2 comments
Open

Outdated OpenZeppelin dependency #132

code423n4 opened this issue Jan 10, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

sirhashalot

Vulnerability details

Impact

The OpenZeppelin library dependency version is 4.2.0 for TimeSwap Core and 4.1.0 for TimeSwap Convenience. Vulnerabilities exist in these older version of OpenZeppelin contracts. Although the vulnerable and outdated portions of OpenZeppelin contracts may not be used by TimeSwap contracts currently, it is always best to apply bug fixes and use the latest version of any dependency.

Proof of Concept

The package.json files in the Core and Convenience folders contain old OpenZeppelin contract versions

Recommended Mitigation Steps

Use the latest version of OpenZeppelin contracts available
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Jan 10, 2022
code423n4 added a commit that referenced this issue Jan 10, 2022
@code423n4
sirhashalot issue #132
e3df9a7
@amateur-dev
Copy link
Collaborator

Similar issue highlighted at #99; hence closing this.

@amateur-dev amateur-dev added the duplicate This issue or pull request already exists label Jan 15, 2022
@0xean
Copy link
Collaborator

0xean commented Jan 26, 2022

not an exact duplicate leaving as non-critical

@0xean 0xean reopened this Jan 26, 2022
@0xean 0xean removed the duplicate This issue or pull request already exists label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @amateur-dev @code423n4