Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assignment not += in function mint (TimeswapPair.sol) #136

Open
code423n4 opened this issue Jan 10, 2022 · 1 comment
Open

Use assignment not += in function mint (TimeswapPair.sol) #136

code423n4 opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

The pool.state.totalLiquidity is increased instead of set to the value directly.
This performs an unnecessary addition as pool.state.totalLiquidity is zero.

Proof of Concept

https://github.com/code-423n4/2022-01-timeswap/blob/bf50d2a8bb93a5571f35f96bd74af54d9c92a210/Timeswap/Timeswap-V1-Core/contracts/TimeswapPair.sol#L161

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Change

pool.state.totalLiquidity += liquidityTotal;

to

pool.state.totalLiquidity = liquidityTotal;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 10, 2022
code423n4 added a commit that referenced this issue Jan 10, 2022
@code423n4
ye0lde issue #136
6265e46
@Mathepreneur Mathepreneur added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jan 18, 2022
@Mathepreneur
Copy link
Collaborator

There is a refactor in the mint function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mathepreneur @code423n4