Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using storage instead of memory to declare struct variable inside the function #141

Open
code423n4 opened this issue Jan 10, 2022 · 1 comment
Open

using storage instead of memory to declare struct variable inside the function #141

code423n4 opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

rfa

Vulnerability details

Impact

more expensive gas

Proof of Concept

https://github.com/code-423n4/2022-01-timeswap/blob/main/Timeswap/Timeswap-V1-Core/contracts/TimeswapPair.sol#L58

instead of caching state on memory. just read it directly from the storage.
State memory state = pools[maturity].state;

Tools Used

self research on:
https://remix.ethereum.org/

Recommended Mitigation Steps

State storage state = pools[maturity].state;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 10, 2022
code423n4 added a commit that referenced this issue Jan 10, 2022
@code423n4
rfa issue #141
ef85f97
@Mathepreneur
Copy link
Collaborator

Timeswap-Labs/Timeswap-V1-Core#110

@Mathepreneur Mathepreneur added resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mathepreneur @code423n4