Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# Pending owner is not cleared #143

Closed
code423n4 opened this issue Jan 10, 2022 · 1 comment
Closed

# Pending owner is not cleared #143

code423n4 opened this issue Jan 10, 2022 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The TimeswapFactory.acceptOwner function does not reset pendingOwner to zero.

Impact

The pending owner can repeatedly accept the governance, emitting an AcceptOwner event each time, bloating listeners for this event with unnecessary data.

Recommended Mitigation Steps

Reset pendingOwner to zero in acceptOwner.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 10, 2022
code423n4 added a commit that referenced this issue Jan 10, 2022
@code423n4
cmichel issue #143
57ffd2e
@amateur-dev
Copy link
Collaborator

Similar issue reported over here #83 ; hence closing this

@amateur-dev amateur-dev added the duplicate This issue or pull request already exists label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amateur-dev @code423n4