Unnecessary checked arithmetic when no overflow/underflow possible (2)

[code423n4]

Handle

Dravee

Vulnerability details

Impact

Increased gas cost.

Proof of Concept

Solidity version 0.8+ comes with implicit overflow and underflow checks on unsigned integers.
When an overflow or an underflow isn't possible (as an example, when a comparison is made before the arithmetic operation), some gas can be saved by using an unchecked block.

https://docs.soliditylang.org/en/v0.8.10/control-structures.html#checked-or-unchecked-arithmetic

Let's look at these lines:

Timeswap-V1-Core\contracts\TimeswapPair.sol:162:            pool.liquidities[factory.owner()] += liquidityTotal - liquidityOut;
Timeswap-V1-Core\contracts\TimeswapPair.sol:168:            pool.liquidities[factory.owner()] += liquidityTotal - liquidityOut;

Here, in MintMath.getLiquidity:L54: liquidityOut is set to a value <= liquidityTotal. Therefore liquidityTotal - liquidityOut cannot underflow.

Tools Used

VS Code

Recommended Mitigation Steps

Uncheck arithmetic operations when possible.

[amateur-dev]

Similar issue highlighted over here #156 ; hence closing this.