Gas optimization in XDEFIDistribution.sol - inlining some functions

[code423n4]

Handle

OriDabush

Vulnerability details

XDEFIDistribution.sol lines 245-251

Make functions like "_getPoints" and "_getPointsFromTokenId" inline (saves the function call gas, the functions can be left and the inline "call" can reference to them with a comment or something)

    function _getPoints(uint256 amount_, uint256 duration_) internal view returns (uint256 points_) {
        return amount_ * (duration_ + _zeroDurationPointBase);
    }

    function _getPointsFromTokenId(uint256 tokenId_) internal pure returns (uint256 points_) {
        return tokenId_ >> uint256(128);
    }


    // old usage:
    return _getPointsFromTokenId(tokenId_);

    // new usage:
    return tokenId_ >> uint256(128);

[deluca-mike]

_getPoints and _getScoreFromTokenId are each used twice, so it's better for that math to be in one place, even if it is trivial. It increases deploy costs but decrease runtime costs such that the breakeven is about 100 calls, which is a good trade-off. Issue is valid, but we won't implement.