Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #145

Open
code423n4 opened this issue Feb 9, 2022 · 4 comments
Open

QA Report #145

code423n4 opened this issue Feb 9, 2022 · 4 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-02-concur/blob/72b5216bfeaa7c52983060ebfc56e72e0aa8e3b0/contracts/ConvexStakingWrapper.sol#L182

Vulnerability details

Impact

There are calls to ERC20 transfer, where safeTransfer should be used instead. Some ERC20 compliant tokens may not revert on failure and instead return false. The use of safeTransfer will mitigate this issue. For more reference, see this medium severity finding of the same issue on a previous C4 contest: code-423n4/2021-11-bootfinance-findings#31.

Proof of Concept

See example of unchecked transfer here.

Tools Used

Inspection.

Recommended Mitigation Steps

Use safeTransfer instead of transfer.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Feb 9, 2022
code423n4 added a commit that referenced this issue Feb 9, 2022
@code423n4
harleythedog issue #145
b70af5f
@r2moon r2moon added the duplicate This issue or pull request already exists label Feb 18, 2022
@r2moon
Copy link
Collaborator

r2moon commented Feb 18, 2022

#263

@GalloDaSballo
Copy link
Collaborator

Dup of #165

@JeeberC4 JeeberC4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed duplicate This issue or pull request already exists 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Apr 21, 2022
@JeeberC4
Copy link

Generating QA Report as warden did not have one and judge downgraded issue. Preserving original title: Unchecked transfers

@JeeberC4 JeeberC4 reopened this Apr 21, 2022
@JeeberC4 JeeberC4 changed the title Unchecked transfers QA Report Apr 21, 2022
@GalloDaSballo
Copy link
Collaborator

1 finding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @r2moon @code423n4 @CloudEllie @JeeberC4