Is Possible onlyGovernance Lock Users Fund by Setting maxWithdrawalProcesses Over Blockchain Gas Limit #70
Labels
bug
Something isn't working
duplicate
This issue or pull request already exists
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Lines of code
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L73-L74
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L48-L50
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L53-L57
Vulnerability details
Impact
ETH Block Gas Limit = 30,000,000
ERC20 Transfer Gas Limit = 65,000
Need Only 462 simple ERC20 Token Transfer to Over Block Gas Limit.
Thus, is possible onlyGovernance Lock Users Fund by Setting maxWithdrawalProcesses Over Blockchain Gas Limit.
Proof of Concept
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L73-L74
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L48-L50
https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/VUSD.sol#L53-L57
Tools Used
Manual Review
Recommended Mitigation Steps
In function setMaxWithdrawalProcesses(), require input _maxWithdrawalProcesses not to More Than Blockchain Gas Limit.
require(_maxWithdrawalProcesses <= 200, 'WithdrawalProcesses Over 200');
The text was updated successfully, but these errors were encountered: